[libdvdnav-devel] [PATCH 22/33] Check for positive integer values

[Andrew Clayton]

On Wed, 21 Jan 2015 17:30:31 +0100, Jean-Baptiste Kempf wrote:

> On 18 Jan, Andrew Clayton wrote :
> > > -  if(cmd_tbl->nr_of_pre != 0) {
> > > +  if(cmd_tbl->nr_of_pre > 0) {
> > 
> > Hmm, would simply
> > 
> > 	if(cmd_tbl->nr_of_pre)
> > 
> > not perhaps be better?, it at least has the same meaning as the old
> > code and for me is quicker to read.
> 
> Ah no, please avoid that for non-boolean or non-pointer values.

Fair enough... btw, just watched your LCA talk... in VLC of course ;)