[vlc-devel] Re: libcddb added, playlist interface - disappointing

[Sigmund Augdal]

Just wanted to say that this function as well could use such a time2string
function. Btw, I don't think secs2TimeStr is a good thing, since most time
variables in vlc are in microseconds.

Sigmund

On Mon, Dec 01, 2003 at 09:51:38AM -0500, R. Bernstein wrote:
> Sigmund Augdal writes:
>  > input_OffsetToTime() also do more or less this function.
> 
> This routine is specific to the mux rate and as a result takes a
> input_thread_t parameter which isn't generally needed/wanted. So it
> looks like the "then" part of this routine should be extracted and put
> somewhere else, e.g. xxx_SecondsToTimeStr(char * psz_buffer, int
> i_secs).
> 
> Then the CD-DA (and later VCD) plugins, the GTK+ gui and
> modules/demux/mkv.cpp routines could all use this. The open question
> then is where. Not sure this is an "input" thing though. 
> 
> And yes, I realized my secs2TimeStr wasn't reentrant - was just moving
> towards a better solution. 
> 
> -- 
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
> If you are in trouble, please contact <postmaster at videolan.org>

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>