[vlc-devel] Re: CVS Commit (rocky)

Sigmund Augdal sigmunau at stud.ntnu.no
Mon Dec 8 14:11:55 CET 2003

On Mon, Dec 08, 2003 at 07:58:08AM -0500, R. Bernstein wrote:
> Sigmund Augdal writes:
>  > I get the sneaking feeling that you forgot a file somewhere. 
> No, I just haven't committed it. 
>  > At least I can
>  > not find the function definition of the ParsePacket and the RenderSPU
>  > functions. Perhaps these are not implemented yet. 
> Correct. One can use dummy stubs for this.
Ok, but it whould perhaps be a good idea to commit such dummy stubs? This
way the code whould at least compile.
>  > In that case, how far from
>  > complete is this decoder?
> The subtitle packets are correctly assembled and the header information is
> parsed. The image data has to be extracted/reformated and what you'd expect
> RenderSPU to do needs to be done.
Are the image data stored as pure bitmaps or as text or with some other

I think perhaps we need to implement some functions to overlay one image in
a chroma on another image in (perhaps) another chroma. This way we could
reduce redundant code (logo filter, freetype renderer, perhaps this decoder
and perhaps the spudec).

> And I have a feeling that were this done, there'd still be the dropout
> problem that one gets that I suspect is caused by the MPEG decoder
> getting confused by these private streams.
Unfortunatly I don't know anything about that.
>  > 
>  > P.S: "Marginally better" is not a very good commitmessage
> Okay. How about "improve modularity slightly and small improvements"
Much better. Even "Small improvements" whould have been better.


This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>

More information about the vlc-devel mailing list