[vlc-devel] more on the ALSA crash

[Derk-Jan Hartman]

Gibalou asked me to test the following to make it easier to spot why 
the ALSA module sometimes crashes.
I have to say that, so far, the alsa plugin hasn't crashed for me since 
that modification.
I have run a full movie and normally, the plugin crashes at least 4 
times during this.

17:41 <gibalou> --- modules/audio_output/alsa.c 3 Aug 2003 23:11:21 
-0000       1.34
17:41 <gibalou> +++ modules/audio_output/alsa.c 21 Sep 2003 15:40:39 
-0000
17:41 <gibalou> @@ -683,7 +683,8 @@
17:41 <gibalou>      int i_snd_rc;
17:41 <gibalou>      mtime_t next_date;
17:41 <gibalou> -    snd_pcm_status_alloca( &p_status );
17:41 <gibalou> +    p_status = (snd_pcm_status_t 
*)malloc(snd_pcm_status_sizeof());
17:41 <gibalou> +    memset( p_status, 0, snd_pcm_status_sizeof() );
17:41 <gibalou>      /* Fill in the buffer until space or audio output 
buffer shortage */
17:41 <gibalou>      {
17:41 <gibalou> @@ -744,6 +745,7 @@
17:41 <gibalou>          if( p_buffer == NULL )
17:41 <gibalou>          {
17:41 <gibalou>              msleep( p_sys->i_period_time >> 1 );
17:41 <gibalou> +            free( p_status );
17:41 <gibalou>              return;
17:41 <gibalou>          }
17:41 <gibalou> @@ -758,4 +760,6 @@
17:41 <gibalou>          aout_BufferFree( p_buffer );
17:41 <gibalou>      }
17:41 <gibalou> +
17:41 <gibalou> +    free( p_status );
17:41 <gibalou>  }

----
Universiteit Twente
Derk-Jan Hartman (d.hartman at student.utwente.nl)
http://home.student.utwente.nl/d.hartman

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>