[vlc-devel] Re: Proposed changes for SAP module

[Derk-Jan Hartman]

I'm against this change. Rather the VLC code should be improved to do  
UDP/RTP packet reordering as well.

DJ


On 28 jun 2005, at 18:32, Marian Durkovic wrote:

> Hi all,
>
>    I'd like to propose some changes in SAP module for VLC, to allow
> it to send all IPv4 XX over RTP streams directly to livedotcom input.
> The main motivation is that livedotcom is able to restore correct
> packet order based on RTP sequence numbers. Packet  
> reordering/duplication
> is unfortunately normal behaviour of some routers/switches and/or  
> network
> topologies (parallel links or redundant routers doing PIM ASSERT  
> mechanism)
> and video glitches every couple of seconds are not uncommon there.
>
>    Obviously, XX over RAW UDP still needs to be handled in vlc because
> of some bugs in live.com library... And thanks to courmisch for  
> pointing
> out to me privately that livedotcom does not support IPv6 yet.
>
>   So I'd propose the following changes in  
> modules/services_discovery/sap.c:
>
> - in function OpenDemux():
>
>     if((p_sdp->i_media_type != 33 && p_sdp->i_media_type != 32 &&
>         p_sdp->i_media_type != 14 ) ||
>        (!strncmp(p_sdp->psz_uri,"rtp",3) && p_sdp->i_in == 4)
>         goto error;
>
> (BTW, it might be also good to check here if "sap-parse" is false like  
> below
> in order give user the option to send e.g. http://foo.bar/x.sdp
> unconditionally into livedotcom input as well)
>
> - in function ParseSAP():
>
>     if( p_sdp->i_media > 1 || ( p_sdp->i_media_type != 14 &&
>                                 p_sdp->i_media_type != 32 &&
>                                 p_sdp->i_media_type != 33) ||
>         p_sd->p_sys->b_parse == VLC_FALSE ||
>        (!strncmp(p_sdp->psz_uri,"rtp",3) && p_sdp->i_in == 4)
>     {
>
>
>    What do you think?
>
>
>
> 	Thanks & kind regards,
>
> 		M.
>
>
> ----------------------------------------------------------------------- 
> ---
> ----                                                                   
> ----
> ----   Marian Durkovic                       network  manager          
> ----
> ----                                                                   
> ----
> ----   Slovak Technical University           Tel: +421 2 524 51 301    
> ----
> ----   Computer Centre, Nam. Slobody 17      Fax: +421 2 524 94 351    
> ----
> ----   812 43 Bratislava, Slovak Republic    E-mail/sip: md at bts.sk     
> ----
> ----                                                                   
> ----
> ----------------------------------------------------------------------- 
> ---
>
> -- 
> This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
> To unsubscribe, please read http://developers.videolan.org/lists.html
>
>
>
---
Universiteit Twente
Derk-Jan Hartman (d.hartman at student.utwente dot nl)
http://www.sidequest.org

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html