[vlc-devel] Re: vlc: svn commit r13050 (md)

[Jean-Paul Saman]

Gildas Bazin wrote:
> On Monday 31 October 2005 07:33, Subversion daemon wrote:
> 
>>r13050 | md | 2005-10-31 08:33:48 +0100 (Mon, 31 Oct 2005) | 2 lines
>>Changed paths:
>>   M /trunk/modules/video_output/directx/directx.c
>>   M /trunk/modules/video_output/directx/glwin32.c
>>
>>make Crop or Aspect change autoamtically resize the window
>>
> 
> 
> Hi Marian,
> 
> I don't actually like this commit because nothing tells you that the user 
> wanted to resize the window to the _original_ size. For instance if the 
> user had already changed the size of the window manually (eg. shrinked or 
> enlarged the video), it is very likely that resizing to the original size 
> is not what the user would expect. At least I know that it would bother 
> me ;)
> 
> I suppose you could resize to the current size of the video sub-window... 
> although I'm not too keen on doing any resizing at all.
> I guess it would be worth having the opinion of other developers here.
> 
> --
> Gildas
> 
If the user resized the window then in my humble opinion the video 
should keep the current aspect ratio and be scaled inside the window. 
Just as VLC did it before this commit.

As a general rule I think that we (developers) shouldn't think that we 
know what the user wants. We should listen to the hints they give eg: 
the size of the window, the aspect ratio setting, the 4:3, 9:6 setting etc.

If the video is automatically resized to its original size then that 
would break intuitive behaviour the user expects. At least that is my 
opinion.

In short I second you Gildas.

Kind Greetings,
Jean-Paul Saman.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html