[vlc-devel] Re: vlc: svn commit r17986 (md)

[Marian Durkovic]

On Thu, Nov 23, 2006 at 10:52:09PM +0100, R?mi Denis-Courmont wrote:
> Le jeudi 23 novembre 2006 20:21, Antoine Cellerier a ?crit :
> > > Fix your compiler then, not VLC code. The code was valid.
> >
> > This comment is stupid.
> 
> Insults eh?
> 
> So proposing a working and fast solution (fixing/upgrading the compiler) 
> is stupid, and forward porting a *non-working* patch without even 
> testing it is intelligent.

I have really enough now.

PLEASE DON'T LIE AT LEAST!

This particular commit was changing:

setsockopt( i_handle, SOL_SOCKET, SO_REUSEADDR, &(int){ 1 }, sizeof( int ));

into:

i_opt = 1;
setsockopt( i_handle, SOL_SOCKET, SO_REUSEADDR, (void *) &i_opt,
                            sizeof( i_opt ));

Don't tell me this in NOT working on your Linux, since in ipv6.c you have
exactly the same:

i_opt = 1;
if( setsockopt( i_handle, SOL_SOCKET, SO_REUSEADDR,
 	                    (void *) &i_opt, sizeof( i_opt ) ) == -1 )

So I only synced ipv4.c with ipv6.c.

And last but not least, if you write code in the standard way i.e.:

int j;
...
for (j = 0; j < p_module->p_config[i].i_list; j++)

instead of:

for (int j = 0; j < p_module->p_config[i].i_list; j++)

which you've commited in 17987, trunk will be compillable with gcc-2.95 
without any additional efforts - the same way as 0.8.x versions are.

	M.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html