[vlc-devel] Re: vlc: svn commit r17986 (md)

[Marian Durkovic]

> 
> From https://trac.videolan.org/vlc/ticket/826, you reported, about the 
> specification of a server name for ASM streams:

Ticket #826 was fixed by your commits 17601-17603 and their respective 
followups. It is pretty fine with me and I haven't complained anymore.

> Now that I 
> remove SSM joins for ASM streams you complain that it should be brought 
> back. How am I supposed to tell which of your conflicting versions is 
> correct?

Noone was asking to bypass the IP_ADD_SOURCE_MEMBERSHIP on the *client-side*.
The problem was on the server side and it was fixed already.

> ... but don't complain again if 
> VLC reintroduces source-filters for ASM streams later on.

You're still not getting the point. 

On the server side:

1) Source-filters should NEVER be made compulsory for ASM
2) Source-filters must be used for SSM (otherwise it doesn't work).

This is now correctly implemented both in trunk and in 0.8.6-branch.

And yes, if you reintroduce compulsory source filters on the server side,
I will have no other chance than to complain again, and not only due
to IGMPv3 bugs. I won't complain if you make them optional (default=off).

> This "ugly hack" allows source filter to work on operating systems that
> do not support IGMPv3/MLDv2

This is valid comment. So the proper implementation should IMHO look like
this:

- try IP_ADD_SOURCE_MEMBERSHIP first
- fallback to IGMPv2 with your hacks if it fails 


The same applies for MLDv2.

 
	With kind regards,

		M.

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html