[vlc-devel] [Patch] Mac OS X gui: Prioritize App's main menu key equivalent over libvlc's

Pierre d'Herbemont pdherbemont at free.fr
Sat Feb 10 17:11:55 CET 2007


This patch fix the bug of the non appearing fspanel, when hitting  
command-F on the Controller Window.

Step to reproduce:
1- Launch VLC on Mac OS X by double-clinking on it
2- Play a video
3- Make the Controller Window the frontmost window by hitting Command- 
4- Hit Command-F
5- The fspanel does not show
5- The fspanel shows up

I am not that happy with this patch. I would really have preferred to  
remove the "hasDefinedShortcutKey:" call as I am not sure that the  
libvlc key equivalents are really a feature in use, and anyway I  
think a case by case cocoa wrapper for those would be more  
appropriate. Could you correct me on that?


Prioritize App's main menu key equivalent over libvlc's
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: full_screen_bug.diff.txt
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070210/cb2be413/attachment.txt>

More information about the vlc-devel mailing list