[vlc-devel] Re: [PATCH] italic tag support fo MPL2 subtitles

[Rémi Denis-Courmont]

Le mardi 20 février 2007 20:54, Roman Bednarek a écrit :
> > Hmmph, this patch seems to be using valid printable character
> > sequences as escape codes for italic. IMHO, this is not a good idea
> > at all.
>
>    I considered using non printable ESC=27(ascii) as an escape code,
> but I was not sure how other renderers will react to it

They won't react very well to extraneous antislashes either.

Should probably define a new FOURCC where whatever is an escape code is 
an escape character, and make sure you are doubling genuine antislashes 
when using that FOURCC. Then a stub de-escaping function that just 
strips italics in any subtitle renderer that cannot implement italics, 
so as not to skip subtitles altogether.

One option is to use real ANSI escape codes, perhaps (sticking to only 
italics on and off for the time being).

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20070220/e8426c36/attachment.sig>