[vlc-devel] Re: [PATCH] italic tag support fo MPL2 subtitles

[Roman Bednarek]

On Tue, 20 Feb 2007, [windows-1252] Rémi Denis-Courmont wrote:

> Le mardi 20 février 2007 20:54, Roman Bednarek a écrit :
>>> Hmmph, this patch seems to be using valid printable character
>>> sequences as escape codes for italic. IMHO, this is not a good idea
>>> at all.
>>
>>    I considered using non printable ESC=27(ascii) as an escape code,
>> but I was not sure how other renderers will react to it
>
> They won't react very well to extraneous antislashes either.
>

   They will be simply displayed I guess, I was afraid that ESC can crash 
them.

> Should probably define a new FOURCC where whatever is an escape code is
> an escape character, and make sure you are doubling genuine antislashes
> when using that FOURCC. Then a stub de-escaping function that just
> strips italics in any subtitle renderer that cannot implement italics,
> so as not to skip subtitles altogether.

   When I change the escape character back to ESC=27, then FOURCC will not 
be needed as it is not possible that it will be accidentaly embedded into 
subtitles?
   I just postponed adding a de-escaping function, where should I place it? 
It is needed in every other text renderer, just copy it two times?

>
> One option is to use real ANSI escape codes, perhaps (sticking to only
> italics on and off for the time being).
>
   It is not good enough, as italics are only one of the tags.

Regards
Roman Bednarek