[vlc-devel] Re: [PATCH] italic tag support fo MPL2 subtitles

[Remi Denis-Courmont]

On Wed, 21 Feb 2007 09:26:27 +0100 (CET), Roman Bednarek <roman at mikronika.com.pl> wrote:
>>>    I considered using non printable ESC=27(ascii) as an escape code,
>>> but I was not sure how other renderers will react to it
>>
>> They won't react very well to extraneous antislashes either.
>>
> 
>    They will be simply displayed I guess,

That would suck badly. No way.

>> Should probably define a new FOURCC where whatever is an escape code is
>> an escape character, and make sure you are doubling genuine antislashes
>> when using that FOURCC. Then a stub de-escaping function that just
>> strips italics in any subtitle renderer that cannot implement italics,
>> so as not to skip subtitles altogether.
> 
>    When I change the escape character back to ESC=27, then FOURCC will not
> be needed as it is not possible that it will be accidentaly embedded into 
> subtitles?
>    I just postponed adding a de-escaping function, where should I place
> it?

Depends how complicated it is. Trivial functions can be inlined in include/
More complex ones can go in src/text/ if code duplication is to be avoided.

>> One option is to use real ANSI escape codes, perhaps (sticking to only
>> italics on and off for the time being).
>>
>    It is not good enough, as italics are only one of the tags.

It has italic, bold, faint, slow blinking, fast blinking, underline,
double underline, black, white, red, green, blue, cyan, yellow, purple,
bright variants of all these 8 colors, exponent, subscript, and a few
other stuff.

Unless you want a real RGB scale, it should be good enough.

--
Rémi Denis-Courmont
http://www.remlab.net/

-- 
This is the vlc-devel mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://developers.videolan.org/lists.html