[vlc-devel] Patches to add support for speex codec in RTP

[Hawkins, William - AES]

Yes, that was an oversight. Speex supports a few other sample rates in their wideband and ultra-wideband versions. The 8kHZ is considered the default but it definitely should NOT be hardcoded that way. I tried to remove most of my newlines from error/debug/warning messages but obviously missed a few. I will check on those before I send out a revised set of patches.

Thanks for the feedback!
Will


-----Original Message-----
From: Rémi Denis-Courmont [mailto:rdenis at simphalempin.com]
Sent: Fri 9/7/2007 10:17 AM
To: vlc-devel at videolan.org; Hawkins, William - AES
Cc: chris.robson at nrl.navy.mil
Subject: Re: [vlc-devel] Patches to add support for speex codec in RTP
 

	Hello,

Le vendredi 7 septembre 2007 16:26, Hawkins, William - AES a écrit :
> I would like to submit these patches that will add support to VideoLAN for
> sending/receiving a Speex encoded audio stream via RTP. The patches make
> changes to the following files:

Thanks. Now we might have an unencumbered streamable audio codec!

The RTP packetization part seems to use audio sample frequency for the RTP 
clock, but then it declares an hard-coded clock frequency of 8000 for the 
payload type mapping. I suppose Speex onle supports 8000Hz, but it does not 
look very consistent.

Otherwise, you should probably not put "\n" at the end of debug messages.

Regards,

-- 
Rémi Denis-Courmont
http://www.remlab.net/

*****************************************************************
This e-mail and any files transmitted with it may be proprietary 
and are intended solely for the use of the individual or entity to 
whom they are addressed. If you have received this e-mail in 
error please notify the sender. Please note that any views or
opinions presented in this e-mail are solely those of the author 
and do not necessarily represent those of ITT Corporation. The 
recipient should check this e-mail and any attachments for the 
presence of viruses. ITT accepts no liability for any damage 
caused by any virus transmitted by this e-mail.
*******************************************************************