[vlc-devel] commit: small rebert for i_length, enables to get meta itags from mp4 again . (Ilkka Ollakka )

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Sat, 12 Apr 2008 01:52:19 +0300,
Ilkka Ollakka <ilkka.ollakka+vlc at oamk.fi> a écrit :

> On pe 11. huhtikuuta 2008 23:16:07, Rafaël Carré wrote:
> > Le Fri, 11 Apr 2008 23:00:29 +0200 (CEST),
> > git at videolan.org (git version control) a écrit :
> > 
> > > vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Fri
> > > Apr 11 23:57:57 2008 +0300|
> > > [e4d12029b07243b6ef4b14ffd51d4461ba211ca0]
> > > 
> > > small rebert for i_length, enables to get meta itags from mp4
> > > again.
> > 
> > > -    i_length = i16 + 1;
> > > +    i_length = i16;
> > 
> > Can you describe what was going on ?
> > This variable only holds the length of the tag, so I don't see how
> > it harms.
>  
>  Actually it didn't read itags with that +1, on next if-check it
> checks itunes/quicktime tags if i_length <=0, and it was earlier
> correctly. so all that +1 affected there, was that it missed some
> itunes tags. that i_length there didn't affect any reading length, as
> it is only used for indicading tag-type from itunes tags and other,
> if I'm not totally lost how it behaves.

The correct fix (according to courmisch's commit) seems to use
if( i_length > 1 ) to me then, because you'll miss 1 character if the
tags are not set by apple stuff.

- -- 
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFH/+2ZYWCeGMCv8Q8RAsyrAKDCijMrafmpaRbtkxdbHg6mhf0HhQCeLlam
JlMBqrQtqWkfwsEOthjlKX0=
=Uw1V
-----END PGP SIGNATURE-----