[vlc-devel] commit: Revert "Turn on -Werror for libvlccore and libvlc." ( Rémi Denis-Courmont )

[Pierre d'Herbemont]

On Aug 13, 2008, at 7:14 PM, Rémi Denis-Courmont wrote:

> Le mercredi 13 août 2008 19:50:16 Pierre d'Herbemont, vous avez  
> écrit :
>> That's an argument for -Werror actually :) Most of the time behind a
>> sanity check warning lies a missing check, else no point to warn.
>
> Heck no. It is difficult enough to build VLC without -Werror.

Agreed.

> A warning is a warning is a warning. According to the GCC  
> documentation
> itself, "warnings are made optional because GCC is not smart enough  
> to see
> all the reasons why the code might be correct despite appearing to  
> have an
> error". And my experience is that other compilers are much worse.


Ok. Do you agree then to turn -Werror when building when --enable-debug?

The idea is to get enough of us to build with -Werror, without trying  
to afraid new comers.

An other idea is to --enable-werror on buildbot.

Please pick one :)

Pierre.