[vlc-devel] Dynamic rendering for Kate streams

[Christophe Mutricy]

On Tue, Nov 18, 08 at 11:07 +0100, ogg.k.ogg.k at googlemail.com wrote:

Small comments

> +          AC_MSG_ERROR([libtiger do not appear to be installed on your system.])

Grammar: does

> +#define TIGER_DEFAULT_FONT_EFFECT_TEXT N_("Default font effect")
> +#define TIGER_DEFAULT_FONT_EFFECT_STRENGTH_TEXT N_("Default font effect")
Identical strings

> +#define TIGER_DEFAULT_FONT_RED_TEXT N_("Default font color (red)")
> +#define TIGER_DEFAULT_FONT_GREEN_TEXT N_("Default font color (green)")
> +#define TIGER_DEFAULT_FONT_BLUE_TEXT N_("Default font color (blue)")

Maybe using something like the html colors ro RRGGBB in hexadecimal
would be more practical.


One more elaborate way, is to add a add_colour() functions so that GUI
can implement a nice colour wheel to choose the colour.

> -    set_capability( "decoder", 50 )
> +    set_capability( "decoder", 100 )
What's the rational ? Is there other codec able to decode kate ?


> Subject: [PATCH] add libtiger to the contribs
> +	(cd $@; autoconf)

Why is that needed?


It also needs to be added in Distributions/*.mak on OS/arch where we
think it's relevant

-- 
Xtophe