[vlc-devel] commit: rtp sout: implement rtptime parameter (Pierre Ynard )

[Rémi Denis-Courmont]

Le lundi 7 décembre 2009 21:27:23 Pierre Ynard, vous avez écrit :
> > You know what? You *suck*.
> >
> > You post patches for review, and then you ignore the review. If you
> > don't want reviews, then you don't post your patch for review in the
> > first place.
> 
> I value your reviews. I believe that I care more about what you tell me
> than you do.
> 
> Your review was:
> > Would be nice to comment the locking scheme in the code too.
> 
> And I took that into account.
> 
> > Not to mention that this patch is incorrect as it won't even return
> > the correct timestamp.
> 
> Well you told me about that on IRC *after* I pushed that commit, whereas
> it was clearly commented in the patch you reviewed:

I told you that this seemed lack locking, and that the race would be limitted 
if seqnum and TS were read under the same lock. I think that was way before 
the commit.

-- 
Rémi