[vlc-devel] commit: Segregate vout window types ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

On Wed, 11 Feb 2009 22:59:10 +0100, "Felix Paul Kühne"
<fkuehne.videolan at googlemail.com> wrote:
> I'm wondering whether this commit is really necessary. I don't have
> the time and more importantly not the knowledge to fix this for Mac OS
> X. So, it is up to fellow OS X developers (which seem to lack time
> too) and other people with vout knowledge. Or we just revert and post-
> pone this API change with no user impact to VLC 1.1.

Yeah, lets continue to ship libvlc with broken-by-design APIs.

> Additionally, I would like to underline that committing this kind of
> stuff one day ahead of a Feature Freeze

One day ahead of the feature freeze is one day ahead of the feature freeze
is one day *ahead* of the feature freeze.

> the _obvious_ breakage of an entire port which got the 2nd largest

It might be obvious to someone who knows the OSX port.

> user base of VLC (okay, you surely don't care about the latter) is no
> good move.

Indeed, I don't. If we had been waiting for the OSX port, we would not even
have half of the enhancements we have in 1.0.

> I had to spend a couple of hours of my spare time to find
> this commit as "Segregate vout window types" without any explanation
> is not exactly obvious. A person who blames people on this list about
> missing documentation and bad behaviour should know better!

It was discussed on this very mailing list several days ahead, even with
Olivier supporting the change

-- 
Rémi Denis-Courmont