[vlc-devel] RC interface logic erros
kenself at optusnet.com.au
Fri Jan 16 00:53:25 CET 2009
My apologies for my previous poor subject heading
Since then I've done some research and find that the code in question
has always been like that so its the setting of the Input states that
has gone awry recently. I'm working through them to see how to fix
things - akin to my option (4)
On Fri, 2009-01-16 at 08:16 +1100, ken wrote:
> On Thu, 2009-01-15 at 17:39:00 +0200, R?mi Denis-Courmont wrote:
> > If I'm not mistaken, your patch would introduce a reference leak on the
> > playlist. I merged the buffer part - please separate such things next time.
> Quite right, I missed that one. However, the logic is just plain wrong.
> PLAYLIST_PAUSED and PAUSE_S are from different domains and cannot both
> be compared against the same value. In fact, PLAYLIST_PAUSED has the
> same value (2) as PLAYING_S so the code returns an error condition
> incorrectly nearly all the time. This means that almost NONE of the rc
> functionality works anymore.
> I've just had a loser look and this additional test against
> PLAYLIST_PAUSED has been added in some other places as well so now I
> have a dilemma. What is the best thing to do?
> 1) Make the same change as I submitted with an additional pl_Release in
> all those places
> 2) Remove the additional condition - if the logic is so bad maybe the
> whole idea is misguided
> 3) Do (2) plus do something that changes the stream state when the
> playlist state changes
> 4) Combine the playlist states with the stream states so they do not
> have overlapping values.
> Ideas welcome from anyone interested
> Kind regards
More information about the vlc-devel