[vlc-devel] commit: Port panoramix to X RandR with XCB (incomplete) ( Rémi Denis-Courmont )

Pierre Ynard linkfanel at yahoo.fr
Thu Jun 25 01:19:46 CEST 2009


Let's face it, VLC coding styles are plain nonsense. Nobody does that,
it's ugly, repulsive and confusing to newcomers. Hungarian notation is
brain-dead, type-checking is the compiler's job, and most often if you
can't figure out the type of the variable by looking at it, then you
chose a poor name for it, and should fix that instead.

> I don't disagree that the standing convention could be more sensible,
> in fact I share your dislike for the whole thing, but we do complain to
> everyone who gratuitously picks a different convention, and rightly so.
> Bad convention or not, as long as it is consistent it beats mixing as
> many styles as possible.

I disagree. I'm not going to promote using bad conventions, and I think
they should be got rid of. While editing existing code just for the sake
of it would be a bad thing, I think using better coding styles for new
code is the right thing to do.

But I don't mean in any way to be aggressive, because in fact I don't
really care. I can stand ugly coding styles, mixed ones... it's not an
issue to me.

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."



More information about the vlc-devel mailing list