[vlc-devel] commit: Port panoramix to X RandR with XCB (incomplete) ( R?mi Denis-Courmont )

jpd at videolan.org jpd at videolan.org
Thu Jun 25 11:31:34 CEST 2009

On Thu, Jun 25, 2009 at 01:19:46AM +0200, Pierre Ynard wrote:
> Let's face it, VLC coding styles are plain nonsense. Nobody does that,
> it's ugly, repulsive and confusing to newcomers. Hungarian notation is
> brain-dead, type-checking is the compiler's job, and most often if you
> can't figure out the type of the variable by looking at it, then you
> chose a poor name for it, and should fix that instead.

Yes, jein (that's a ``feature'' of C, of sorts), yes.

Personally I think all of the code under ``gnu coding style'' is much,
much worse.

> > Bad convention or not, as long as it is consistent it beats mixing as
> > many styles as possible.
> I disagree. I'm not going to promote using bad conventions, and I think
> they should be got rid of. While editing existing code just for the sake
> of it would be a bad thing, I think using better coding styles for new
> code is the right thing to do.

We have a volunteer to reformat the code base then?

AFAIK the standing convention is to keep consistent with existing code
on a file granular basis. It'd be nice to stick to that, as it both
helps not having too much multiple style confusion and lets us reformat
parts on a file-by-file basis.

That comes down to reformatting an entire file, committing that under
"cosmetics: style reformat", and only _then_ doing your thing in your
preferred style.

I don't think that's too much to ask and I do think that some
consistency is a good thing.

More information about the vlc-devel mailing list