[vlc-devel] [PATCH] Add support for mpg123 decoder
will07c5 at gmail.com
Thu Apr 15 03:52:29 CEST 2010
Sorry for the delay, I've been very busy with school lately. I fixed
the issues you identified as well as some other minor stuff (missing
p_ prefix on a pointer). I noticed that the VLC_SUCCESS was also
missing in the original mpgatofixed32.c so I probably will make a
patch for that too.
William Hahne (IRC: Will07c5)
On Tue, Apr 13, 2010 at 6:10 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Thu, Apr 01, 2010 at 02:59:00PM -0600, William Hahne wrote :
>> Since mpgatofixed32 needs the extra 8 bytes, it is easier to remove
>> the bytes than store the frame and wait until the next one before
>> sending them to mad. I just made mpgatofixed32_mpg123 remove the last
>> 8 bytes. I can do it the other way but it will have to wait until next
>> week since I really need to spend time writing my proposal and dealing
>> with all the homework I have to do.
> - Copyright and dates are wrong and AUTHORS too.
> - Configure.ac should use PKG_CONFIG instead of this complex detection
> - I believe filter_sys_t should be reordered (or maybe off_t isn't a long )
> - I believe you should return VLC_SUCCESS and not 0 in OpenFilter
> - I believe you are leaking p_sys when VLC_EGENERIC is throws in OpenFilter
> And that's all from me ;)
> Jean-Baptiste Kempf
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 10678 bytes
Desc: not available
More information about the vlc-devel