[vlc-devel] Solaris configuration scripts fixes

[Rémi Denis-Courmont]

On Sun, 17 Jan 2010 19:20:30 +0100, Francois Cartegnie <fcartegnie at free.fr>
wrote:
> Le Sunday 17 January 2010, Rémi Denis-Courmont a écrit :
>> > Solaris's /bin/sh isn't a fully compliant shell and fails
>> > in configuration scripts. We needed a fix to override the
>> > hardcoded /bin/sh. (here using CONFIG_SHELL)
>> 
>> "compliant" with what? If the bug is in Solaris, the fix belongs in
>>  Solaris.
> 
> Posix Compliant.
> http://www.gnu.org/software/autoconf/manual/html_node/Shellology.html
> 
> Systems are free not to have a posix compliant shell or not to have a
> /bin/sh shell.

POSIX does specify that 'sh' is a POSIX-compliant shell:
http://www.opengroup.org/onlinepubs/9699919799/utilities/sh.html

> So this isn't a solaris bug and vlc must build from any user
> specified shell. (and shell isn't specified by pkg-config)

The user may want to use a non-POSIX-shell, can't (s)he? Then VLC cannot
use that shell, or rather, cannot assume it can use the user's $(SHELL).
However, it can assume that 'sh' is POSIX-compliant.

Then, as far as VLC is concerned, there is a bug. We should prefix the
script invocation with 'sh '.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis