[vlc-devel] [vlc-commits] commit: access_http: use only the provided user agent. ( Rémi Duraffort )

[Ilkka Ollakka]

On Fri, Jul 30, 2010 at 10:32:27AM +0200, Rémi Duraffort wrote:
> Le jeudi 29 juillet 2010 à 10:26:26, Rémi Denis-Courmont a écrit :
> > Le jeudi 29 juillet 2010 14:08:14 Rémi Duraffort, vous avez écrit :
> > > That's the default user agent (name/version), but if people uses the option
> > > to change the user agent I think they expect to control it complitely and
> > > not only one part of it.

> > I don't expect the user to set it up itself, only SD, playlists or such.

> In this case setting the user-agent to exactly what the SD script asks
> seams logical to me.

Actually most cases user-agent is added just that server can match
certain string, I don't think any of those user-agent lookup tries to
match whole string, only tries to find one certain part in there (like
quicktime/7 for apple etc). And I agree with courmisch here, that we
should have libvlc/version un http-user agent.

> > Second, I still fail to see the harm in adding LibVLC at the end. I do see the 
> > harm in _not_ adding it.

> I don't know if it harms or not but I see this as some kind of a bug. If
> we provide an option to override the user agent, it might override it.
> Maybe the name of the option/variable or the help text is not suitable ?

We could mention that we add libvlc/version to http-user agent string,
but otherwise it seems to be correct, as user_agent handles also
application name toward pulseaudio etc?


> best regards
-- 
Ilkka Ollakka
Don't get even -- get odd!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100730/7838dc62/attachment.sig>