[vlc-devel] Symbian Threading System for Review

[Rémi Denis-Courmont]

On Mon, 14 Jun 2010 20:39:38 +0530, Pankaj yadav <pankajdnapster at gmail.com>
wrote:
> This is the Threading System I am going to use in Symbian Port and
> present it for your review.
> 
> Attached Files are  :
> 
> =>FILE: vlc_symbian_fixups.h replaces all occurences of cancellation
> points(say acept()) with wrappers

IIRC, VLC currently expects a cancellation point in the following leaf
functions:
 - msleep and mdate,
 - vlc_cond_wait and vlc_cond_timedwait,
 - vlc_join,
 - poll or vlc_poll,
 - vlc_testcancel.

All of those, except poll() are LibVLC functions. So I think you don't
really need the #define hacks. You can just do the cancellation support
directly in the function, no? For poll(), we already have wrapper
implementation in src/network/poll.c. Look for HAVE_MAEMO to see how you
can define poll() to vlc_poll() and override the implementation to handle
cancellation as you need.

> =>FILE: symbian_threads.cpp  This file has all Thread Functions and
> Wrapper functions actually Implemented

Please _indent_ your code. It's a pain to review as is.

Best regards,

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis