[vlc-devel] rate in playlist variable also? Was: [vlc-commits] commit: Qt4: don't reset rate when input changes (Ilkka Ollakka )

[Jean-Paul Saman]

On Tue, Sep 14, 2010 at 10:25 PM, Ilkka Ollakka <ileoo at videolan.org> wrote:
> On Mon, Sep 13, 2010 at 09:47:28AM +0300, Ilkka Ollakka wrote:
>> On Mon, Sep 13, 2010 at 07:18:35AM +0300, Rémi Denis-Courmont wrote:
>
>> Hi,
>
>> > That being said, I find Ilkka's hack rather ugly. Why does Qt4 need to set the
>> > input rate at all?! (other than when the user plays with the scroller)
>
>> Yes you're right, it's pretty ugly hack. I'll try to get my head around
>> howto move it into core.
>
> If I got it right, it should be as simple as adding rate variable to
> playlist also and modify that from gui instead inputs rate ? seems that
> best would be to move all rate related variables under playlist in this
> case. Anyone knows case that this would be bad/breaks other than simple
> p_input -> p_playlist code ?

Be carefull not to break libvlc_ API for rate, which is being used by
browser plugins.

Kind Regards,

Jean-Paul Saman