[vlc-devel] Dash Access Plugin status ?

[Christopher Müller]

Hi


> Von: Rémi Denis-Courmont [mailto:remi at remlab.net]
> Gesendet: Mittwoch, 05. Oktober 2011 10:17
> An: vlc-devel at videolan.org
> Cc: Christopher Mueller
> Betreff: Re: [vlc-devel] Dash Access Plugin status ?
> 
> 	Hello,
> 
> Le vendredi 30 septembre 2011 04:54:50 Christopher Mueller, vous avez
> écrit :
> > Today I had time to integrate the changes as requested. Hopefully I
> have
> > not overseen something if so it was not my intent. The patch should
> also
> > fix your problem Frederic because the plugin uses now the vlc xml
> api. I
> > hope that I have some time next week then I will integrate the buffer
> and
> > some other stuff from another branch into this one.
> 
> Please don't output to cout or cerr... We have
> msg_Err()/msg_Warn()/msg_Dbg()

The methods that use cout are only for debug, currently they are not called
somewhere. Anyway I have changed them to msg_Dbg or removed. I don’t use the
msg_Dbg that often due to the fact that it needs a vlc_object.

> for that. Otherwise, it looks OK to me as far as the VLC parts are
> concerned.
> I don't know DASH so I can't review the bulk.

The current version of the standard is of course different to the version
proposed here because I have written it last year where DASH was WD,
currently it is DIS. But the overall structure is the same they have changed
some names and introduced some new elements, attributes, mechanisms and
profiles (special things for ISOBMFF or MPEG2-TS). That was foreseeable
therefore I have tried to make the plugin that flexible as possible. I think
it is a good starting point as it is and it should be relatively easy to
extend/modify the XML part. The profile that is usable with the plugin is
described here [1] and is an extension of the isoff-basic-on-demand profile.

[1] http://www-itec.uni-klu.ac.at/dash/?page_id=10#SupportedProfile

> 
> I guess you made sure that exceptions were caught on all paths, right?

Yes if I have not overseen something.

> 
> Also I did not try to compile yet and I do not have a 64-bits machine,
> but
> Frederic's comments need to be addressed.

Changed every unsigned int to size_t this should fix the problem.

BR and Thanks for the input Frederic/Remi
Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-DASH-stream-filter.patch
Type: application/octet-stream
Size: 200679 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111005/d0887b3e/attachment.obj>