[vlc-devel] [vlc-commits] macosx/sprefs: adapt setting handling to the 2.1 volume API

[David Fuhrmann]

Am 15.12.2012 um 15:20 schrieb Felix Paul Kühne <git at videolan.org>:

> vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sat Dec 15 15:20:07 2012 +0100| [5ff2c7a239dae052f4a4ed95fce3e0e5d66ccb64] | committer: Felix Paul Kühne
> 
> macosx/sprefs: adapt setting handling to the 2.1 volume API
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5ff2c7a239dae052f4a4ed95fce3e0e5d66ccb64
> ---
> 
> modules/gui/macosx/simple_prefs.m |    9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/modules/gui/macosx/simple_prefs.m b/modules/gui/macosx/simple_prefs.m
> index fdaf529..11e4b002 100644
> --- a/modules/gui/macosx/simple_prefs.m
> +++ b/modules/gui/macosx/simple_prefs.m
> @@ -472,8 +472,8 @@ static inline char * __config_GetLabel(vlc_object_t *p_this, const char *psz_nam
>         [o_audio_vol_fld setEnabled: YES];
>         [o_audio_vol_sld setEnabled: YES];
> 
> -        i = config_GetInt(p_intf, "volume");
> -        i = i * 200.0 / AOUT_VOLUME_MAX + 0.5;
> +        i = var_InheritInteger(p_intf, "auhal-volume");

Hi,

Is it really the right way to hard-code "auhal-" here? I suppose that they will be another official way for the qt interface etc where several different potential aout modules exist. So we should also use this way in the mac interface then?

Best regards,
David