[vlc-devel] [PATCH] chorus_flanger.c : bit of cleanup

[Sukrit Sangwan]

On Thu, Mar 15, 2012 at 4:08 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On 15/03/2012 08:44, Sukrit Sangwan wrote:
>
>> I have splitted the patches and renamed them.
>>
>
> Please fix this:
>
> ../../../modules/audio_filter/**chorus_flanger.c: In function 'DoWork':
> ../../../modules/audio_filter/**chorus_flanger.c:257:19: warning: cast
> from function call of type 'double' to non-matching type 'int'
> [-Wbad-function-cast]
>
I have now use floorf() and haven't cast to int.
But i don't know why i didnt get this warning.

../../../modules/audio_filter/**chorus_flanger.c:249:32: warning: variable
> 'f_frac' set but not used [-Wunused-but-set-variable]
> ../../../modules/audio_filter/**chorus_flanger.c:249:20: warning:
> variable 'f_diff' set but not used [-Wunused-but-set-variable]
>
> And please avoid pf_ for floats names
>
I have changed pf_* to p_* for float.

Also i have attached the patch for stereo_widen again (i had attached it
earlier).

-- 
Regards
Sukrit Sangwan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120316/37a21424/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sine oscillator and callbacks in chorus_flanger.patch
Type: text/x-patch
Size: 13117 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120316/37a21424/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: description and help in stereo_widen.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120316/37a21424/attachment-0001.bin>