[vlc-devel] Icon mess and osx build problems

[Felix Kühne]

Hi David,

On Wed, May 2, 2012 at 11:31 AM, David Fuhrmann
<david.fuhrmann at googlemail.com> wrote:
> I just saw #6739 and I think that we should fix that before vlc 2.0.2.
I have a patch for that, which will be pushed and backported in a few minutes.

> I could not figure out at which place vlc48x48.ico is used at all.
It is used by httpd interfaces.

> For vlc512x512.png, this seems to be the wrong place as well, and we should move this file inside the icons folder.
Nope, it is accessed by some of VLC's modules, most notably growl.
Therefore, it needs to be in VLC's own shared folder, since it isn't
necessarily accessed through Cocoa or CoreFoundation.

> Furthermore, Felix commited an xmas icon for 512x512 in extras/package/macosx/Ressources/icons (vlc.git only, IIRC). Perhaps this icon should be moved (copied?) inside share/icons/ as well.
No, because this one is accessed through Cocoa. Additionally, it is a
Mac-specific file and therefore deserves to be in the Mac-specific
resources folder. We are using a different holiday season icon on
Windows and Linux, which can't be used on the Mac since its resolution
is too low. However, there is no reason to update it to the high
resolution one, since Win32 and Linux can't display it anyway.

Hope this helps.

Felix