[vlc-devel] [RFC] transform: add motion detection

Pierre Ynard linkfanel at yahoo.fr
Thu Nov 1 17:15:28 CET 2012

> You cannot assume that the parent is any particular kind of object, only
> that there is one.

Right, but is there any real chance that the parent won't be the vout
object? And if the video output is refactored and changes that, then
it'll be an opportunity to fix the way this is done.

> Also, I think this does not belong in transform because:
> - Transform does not alter the format while running. Motion needs to.

That's why it triggers the recreation of the filter chain. I don't
really see the problem with that, except a mild semantic one maybe.
However contrary to others approaches, this does not needs rewriting the
filter chain or changing variables or anything, which is quite clean in
my opinion.

> - Transform is a top contender for ASM optimizations, that would break.


> - Transform only rotates pictures. Motion should rotate pictures _and_
> subs.

Ah. Is there some place in the video output where you can rotate subs
(or both) ?

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list