[vlc-devel] new aac encoder for review

[Rafaël Carré]

Le 13/10/2012 12:46, Ilkka Ollakka a écrit :
> On Wed, Oct 10, 2012 at 02:04:46PM -0400, Sergio M. Ammirata, Ph.D. wrote:
>>  configure.ac        |    5 +
>>  modules/codec/aac.c |  535 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> Misses Modules.am stuff?
> 
>> +static block_t *EncodeAudio( encoder_t *p_enc, aout_buffer_t *p_buf );
> 
> I think this has changed in current git since May to block_t. Sorry only
> noticed it now when I had time to check compiling and stuff.
> 
>> +            vlc_memcpy( p_block->p_buffer, outbuf, out_args.numOutBytes );
> 
> Use plain memcpy? I was wondering why don't you allocate block before
> encode and give that buffer directly to aacEncEncode? That would save
> memcpy? You could tune block_i->buffer after encode anyway to be correct
> on output amount.

vlc_memcpy() has been removed some time ago already