[vlc-devel] libvlc_media_add_option problem in 2.0.3

[LANGLOIS Olivier PIS -EXT]

Remi,

You have valid concerns. How would you suggest that the problem solution be improved?

I havent checked code diff between 2.0.2 and 2.0.3 but setting windows properties were still working fine in 2.0.2. I'm suspecting that letting the media player creating the properties object is a new addition while it was always created by the input object before.

I did considered placing the the media options processing to the parent object of the properties object and in this case that would mean the media player object. However I did hit a wall because of the libvlc/vlccore separation. Hence I decided to "hack" something that would keep to a minimum the required changes.

That being said, I'm lacking historical context about recent vlc changes to determine the best location to fix the problem. Hopefully, someone in this list will be able to contribute with his knowledge.

-----Original Message-----
From: Rémi Denis-Courmont [mailto:remi at remlab.net]
Sent: Monday, September 03, 2012 5:15 AM
To: vlc-devel at videolan.org
Cc: LANGLOIS Olivier PIS -EXT
Subject: Re: [vlc-devel] libvlc_media_add_option problem in 2.0.3

   Hello,

Le jeudi 30 août 2012 03:57:36, LANGLOIS Olivier PIS -EXT a écrit :
> I was using
>
>                 libvlc_media_add_option(lMedia, "video-x=0");
>                 libvlc_media_add_option(lMedia, "video-y=0");
>                 libvlc_media_add_option(lMedia, "width=320");
>                 libvlc_media_add_option(lMedia, "height=200");
>
> and on any video, the source format was setting my window properties.
> To fix the problem, I did modify src/input/input.c, function Create():

The video output outlives the input, thus there cannot be video output parameters per inputs.

Your hack makes some generally incorrect assumptions. It might work for your specific use case, but unfortunately, it will easily break in practice. For example, settings from the previous item will be passed onto the next item, unless explicitly overriden. Normally, the next item should inherit the defaults.

--
Rémi Denis-Courmont
http://www.remlab.net/

________________________________
CONFIDENTIALITY : This e-mail and any attachments are confidential and may be privileged. If you are not a named recipient, please notify the sender immediately and do not disclose the contents to another person, use it for any purpose or store or copy the information in any medium.