[vlc-devel] [PATCH] Qt: grammar fixes

[Rafaël Carré]

Hi,

Le 13/07/2013 21:38, Edward Wang a écrit :
> 1) At least in English, most proper nouns do not take the definite article "the". Quote: "most proper nouns use no article". Example: "In order to browse the web, Firefox uses the HTTP protocol."
> 
> Notice that it is not "the Firefox uses the HTTP protocol". It is OK to use "the web browser", since 'web browser' is not a common noun.
> 
> We use 'the' in 'the HTTP protocol' because protocol is not a proper noun. HTTP is the adjective describing the protocol.
> 
> Therefore, the 'the' in "In order to ..., the VLC" is awkward and should be removed.
> 
> 2) covert arts → cover art (the artwork is not secret or concealed, by definition in English of covert)
> 
> 'authoring' in English refers to the process/result and not 'artists' as generally used in media players.
> 
> 3) Use 'this'
> 
> From English Language and Usage:
> 
> "For a concept or idea introduced a few sentences before, I think the key thing is whether it was introduced by you or the person you're talking to. If you introduced it, you're "holding" the idea - use "this""
> 
> Since our text introduces the idea of automatic retrival, the correct word to use is 'this'.
> 
> Reference: http://english.stackexchange.com/questions/4325/using-that-and-this-interchangeably
> 
> 4) Consequently
> 
> Improves the flow of the passage by logically explaining a consequence of the first idea.

Thanks, all changes look correct to the french me.

j-b, any word about "the VLC media player" ?

> ---
>  modules/gui/qt4/dialogs/firstrun.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/modules/gui/qt4/dialogs/firstrun.cpp b/modules/gui/qt4/dialogs/firstrun.cpp
> index e66ee7e..448e5b9 100644
> --- a/modules/gui/qt4/dialogs/firstrun.cpp
> +++ b/modules/gui/qt4/dialogs/firstrun.cpp
> @@ -69,16 +69,16 @@ void FirstRun::buildPrivDialog()
>      QGroupBox *blabla = new QGroupBox( qtr( "Privacy and Network Access Policy" ) );
>      QGridLayout *blablaLayout = new QGridLayout( blabla );
>      QLabel *text = new QLabel( qtr(
> -        "<p>In order to protect your privacy, the <i>VLC media player</i> "
> +        "<p>In order to protect your privacy, <i>VLC media player</i> "
>          "does <b>not</b> collect personal data or transmit them, "
>          "not even in anonymized form, to anyone."
>          "</p>\n"
>          "<p>Nevertheless, <i>VLC</i> is able to automatically retrieve "
>          "information about the media in your playlist from third party "
> -        "Internet-based services. That includes covert arts, track names, "
> -        "authoring and other meta-data."
> +        "Internet-based services. This includes cover art, track names, "
> +        "artist names and other meta-data."
>          "</p>\n"
> -        "That may entail identifying some of your media files to third party "
> +        "Consequently, this may entail identifying some of your media files to third party "
>          "entities. Therefore the <i>VLC</i> developers require your express "
>          "consent for the media player to access the Internet automatically."
>          "</p>\n"
>