[vlc-devel] [vlc-commits] avcodec: pass coded dimensions to hardware decoder

[David Fuhrmann]

Am 18.07.2013 um 18:35 schrieb Rémi Denis-Courmont <git at videolan.org>:

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Jul 18 19:04:13 2013 +0300| [01c4f44e88bfbb8ecf108c0fe40f3797bddac686] | committer: Rémi Denis-Courmont
> 
> avcodec: pass coded dimensions to hardware decoder
> 
> Regression from b71c85b3d88b8d0ad2d4a63bf58ebcd2ad771cbf.
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=01c4f44e88bfbb8ecf108c0fe40f3797bddac686
> ---
> 
> modules/codec/avcodec/video.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/codec/avcodec/video.c b/modules/codec/avcodec/video.c
> index 50d0a82..edba52e 100644
> --- a/modules/codec/avcodec/video.c
> +++ b/modules/codec/avcodec/video.c
> @@ -907,7 +907,7 @@ static int ffmpeg_va_GetFrameBuf( struct AVCodecContext *p_context, AVFrame *p_f
>     /* hwaccel_context is not present in old ffmpeg version */
>     if( vlc_va_Setup( p_va,
>                 &p_context->hwaccel_context, &p_dec->fmt_out.video.i_chroma,
> -                p_context->width, p_context->height ) )
> +                p_context->coded_width, p_context->coded_height ) )
>     {
>         msg_Err( p_dec, "vlc_va_Setup failed" );
>         return -1;
> 


Hi,

I noticed that this commit broke VDA hardware decoding. Video is unusable, and the debug log spams messages like the ones below. Reverting this commit switches the behavior back to normal as before.


[0x116177ab0] vda generic debug: VDA decoder created
[h264 @ 0x11884b420] mmco: unref short failure
[h264 @ 0x11884b420] number of reference frames (0+4) exceeds max (3; probably corrupt input), discarding one
[0x116177ab0] vda generic debug: VDA decoder created
[0x116177ab0] vda generic debug: VDA decoder created
[h264 @ 0x11884b420] mmco: unref short failure
[h264 @ 0x11884b420] number of reference frames (0+4) exceeds max (3; probably corrupt input), discarding one
[0x116177ab0] vda generic debug: VDA decoder created
[h264 @ 0x11884c020] reference picture missing during reorder
[h264 @ 0x11884c020] Missing reference picture, default is 65596
[0x116177ab0] vda generic debug: VDA decoder created
[0x116177ab0] vda generic debug: VDA decoder created
[0x116177ab0] vda generic debug: VDA decoder created
[h264 @ 0x11884c620] mmco: unref short failure
[h264 @ 0x11884c620] number of reference frames (0+4) exceeds max (3; probably corrupt input), discarding one
[0x11884f4b0] avcodec decoder error: more than 5 seconds of late video -> dropping frame (computer too slow ?)
[0x1027efeb0] main video output warning: picture is too late to be displayed (missing 99514 ms)
[0x116177ab0] vda generic debug: VDA decoder created


With best regards,
David