[vlc-devel] [vlc-commits] configure: unbreak cross-pkg-config support with contrib

[Rémi Denis-Courmont]

On Mon, 03 Mar 2014 15:07:16 +0100, Rémi Denis-Courmont <remi at remlab.net>
wrote:
>> What is 'cross-pkg-config tools' exactly ?
> 
> $(CROSS)-pkg-config.
> 
>> I only saw something like this in Fedora and I have no idea yet how
>> hacky it is.
> 
> Debian does it too and I believe it is part of pkg-config.

Indeed, that actually comes from upstream pkg-config, not from Debian
mingw64-tools. The automake macro calls AC_CHECK_TOOL expecting a
$(host)-specific cross-tool (as opposed to AC_CHECK_PROG) just like the
compiler and the linker. So this commit is just matching the expected
pkg-config usage.

Generally speaking, it is not the job of the contrib snippet of the VLC
configure script to guess whether the pkg-config environment is right or
wrong, anymore than that of other build tools. That is the job of the
caller (of the script) or of the SDK. The --with-contrib option is meant to
*add* contribs to the search path.

Besides, comparing $host with $build means nothing (save maybe that you
can run test cases). The caller may well want to override the pkg-config
search path on native compilation. So even if we considered that the VLC
configure script should fix broken pkg-config setups, the test was wrong.

-- 
Rémi Denis-Courmont
Sent from my collocated server