[vlc-devel] vlc-devel Digest, Vol 93, Issue 9
Rohit Kashyap
rkgudboy at gmail.com
Sun Feb 8 18:16:18 CET 2015
I an new in community, and would request the Mentors to help me head start in bug fixing and contribute in VLC with introductory bugs or tutorial.
-----Original Message-----
From: "vlc-devel-request at videolan.org" <vlc-devel-request at videolan.org>
Sent: 08-02-2015 16:30
To: "vlc-devel at videolan.org" <vlc-devel at videolan.org>
Subject: vlc-devel Digest, Vol 93, Issue 9
Send vlc-devel mailing list submissions to
vlc-devel at videolan.org
To subscribe or unsubscribe via the World Wide Web, visit
https://mailman.videolan.org/listinfo/vlc-devel
or, via email, send a message with subject or body 'help' to
vlc-devel-request at videolan.org
You can reach the person managing the list at
vlc-devel-owner at videolan.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of vlc-devel digest..."
Today's Topics:
1. [PATCH] subpicture: fix memory leaks (Hannes Domani)
2. access: rar: fix memory leaks of unused naming scheme
(Hannes Domani)
3. Re: [PATCH] Fix pan handling for changing volume/brightness
(Filipe Cabecinhas)
4. [PATCH] avcodec: fix double free on failure to open audio
(Alex Converse)
5. Re: [vlc-commits] demux: mpeg: add some more DTS header
checks (fix #13843) (Jean-Baptiste Kempf)
6. Re: [PATCH] avcodec: fix double free on failure to open audio
(Jean-Baptiste Kempf)
7. Re: [PATCH] avcodec: fix double free on failure to open audio
(Alex Converse)
8. Re: [PATCH] avcodec: fix double free on failure to open audio
(Jean-Baptiste Kempf)
----------------------------------------------------------------------
Message: 1
Date: Sat, 7 Feb 2015 15:01:24 +0000 (UTC)
From: Hannes Domani <ssbssa at yahoo.de>
To: vlc-devel <vlc-devel at videolan.org>
Subject: [vlc-devel] [PATCH] subpicture: fix memory leaks
Message-ID:
<1421657069.1255367.1423321284476.JavaMail.yahoo at mail.yahoo.com>
Content-Type: text/plain; charset="utf-8"
Hello
Again some of those palette leaks.
Regards
Domani Hannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-subpicture-fix-memory-leaks.patch
Type: application/octet-stream
Size: 816 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150207/0b36a427/attachment-0001.obj>
------------------------------
Message: 2
Date: Sat, 7 Feb 2015 15:11:20 +0000 (UTC)
From: Hannes Domani <ssbssa at yahoo.de>
To: vlc-devel <vlc-devel at videolan.org>
Subject: [vlc-devel] access: rar: fix memory leaks of unused naming
scheme
Message-ID:
<1409788443.1242872.1423321880061.JavaMail.yahoo at mail.yahoo.com>
Content-Type: text/plain; charset="utf-8"
Hello
I was a bit surprised when I saw that both naming variants were checked.
Isn't it encoded in the header which variant is used?
Regards
Domani Hannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-access-rar-fix-memory-leaks-of-unused-naming-scheme.patch
Type: application/octet-stream
Size: 1701 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150207/69c6dd95/attachment-0001.obj>
------------------------------
Message: 3
Date: Sat, 7 Feb 2015 11:03:08 -0800
From: Filipe Cabecinhas <vlc at filcab.net>
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] Fix pan handling for changing
volume/brightness
Message-ID: <9FCAC07C-F688-448C-A902-E8FD34B4671F at filcab.net>
Content-Type: text/plain; charset=utf-8
Hi Felix,
Sorry, I forgot about that list again (but I'm subscribed).
I'll start sending patches that way, if I'm doing iOS related stuff.
Thanks,
Filipe
> On Feb 7, 2015, at 01:38, Felix Paul K?hne <fkuehne at videolan.org> wrote:
>
> Hello Filipe,
>
>> On 07 Feb 2015, at 07:26, Filipe Cabecinhas <vlc at filcab.net> wrote:
>>
>> Commit 479cc4b3 ended up breaking our ability to pan and easily change
>> volume/brightness.
>>
>> This fixes it, and makes our panRecognized: event handler more efficient
>> by avoiding string comparisons.
>
> Merged, thanks a lot!
>
> To monitor our development activities on iOS and to directly send patches to the iOS team, you are welcome to join our iOS mailing-list :)
>
> Cheers,
>
> Felix
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
------------------------------
Message: 4
Date: Sat, 7 Feb 2015 12:30:32 -0800
From: Alex Converse <alex.converse at gmail.com>
To: vlc-devel at videolan.org
Subject: [vlc-devel] [PATCH] avcodec: fix double free on failure to
open audio
Message-ID: <1423341032-2565-1-git-send-email-alex.converse at gmail.com>
---
modules/codec/avcodec/audio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/modules/codec/avcodec/audio.c b/modules/codec/avcodec/audio.c
index a37f1cf..514f76d 100644
--- a/modules/codec/avcodec/audio.c
+++ b/modules/codec/avcodec/audio.c
@@ -261,7 +261,6 @@ int InitAudioDec( decoder_t *p_dec, AVCodecContext *p_context,
/* ***** Open the codec ***** */
if( OpenAudioCodec( p_dec ) < 0 )
{
- av_free( p_context->extradata );
free( p_sys );
return VLC_EGENERIC;
}
--
1.9.1
------------------------------
Message: 5
Date: Sun, 8 Feb 2015 09:03:00 +0100
From: Jean-Baptiste Kempf <jb at videolan.org>
To: vlc-devel at videolan.org
Cc: vlc-commits at videolan.org
Subject: Re: [vlc-devel] [vlc-commits] demux: mpeg: add some more DTS
header checks (fix #13843)
Message-ID: <20150208080300.GA7201 at videolan.org>
Content-Type: text/plain; charset=us-ascii
On 07 Feb, Francois Cartegnie wrote :
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Sat Feb 7 19:56:14 2015 +0100| [1f0c9de8b05929cd24cc23d0ec26678ce5ba2d8b] | committer: Francois Cartegnie
>
> demux: mpeg: add some more DTS header checks (fix #13843)
It also fixes #8803, #10477, 1 sample out of 2 of #8387.
With my kindest regards,
--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
------------------------------
Message: 6
Date: Sun, 8 Feb 2015 09:18:36 +0100
From: Jean-Baptiste Kempf <jb at videolan.org>
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] avcodec: fix double free on failure
to open audio
Message-ID: <20150208081836.GA9023 at videolan.org>
Content-Type: text/plain; charset=us-ascii
On 07 Feb, Alex Converse wrote :
> ---
> modules/codec/avcodec/audio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/modules/codec/avcodec/audio.c b/modules/codec/avcodec/audio.c
> index a37f1cf..514f76d 100644
> --- a/modules/codec/avcodec/audio.c
> +++ b/modules/codec/avcodec/audio.c
> @@ -261,7 +261,6 @@ int InitAudioDec( decoder_t *p_dec, AVCodecContext *p_context,
> /* ***** Open the codec ***** */
> if( OpenAudioCodec( p_dec ) < 0 )
> {
> - av_free( p_context->extradata );
> free( p_sys );
> return VLC_EGENERIC;
> }
I have a hard time seeing where the extradata is, in fact, freed.
And I guess we have the same issue with subtitle part.
With my kindest regards,
--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
------------------------------
Message: 7
Date: Sun, 8 Feb 2015 00:42:20 -0800
From: Alex Converse <alex.converse at gmail.com>
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] avcodec: fix double free on failure
to open audio
Message-ID:
<CALXxgACz5UkCspbYmziV7pGxrGZiSutjt+tmH8bv2JQBqVn2Vg at mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
So it's freed in avcodec_free_context() its been freed there in all
versions of libav and ffmpeg that have that function. It's also freed in
the current version of VLC compat but not older versions.
See
http://git.videolan.org/?p=vlc.git;a=commitdiff;h=a9ac943471c67fb3416f21246e389decda12cc38
for a the relevant compat change.
On Feb 8, 2015 12:18 AM, "Jean-Baptiste Kempf" <jb at videolan.org> wrote:
> On 07 Feb, Alex Converse wrote :
> > ---
> > modules/codec/avcodec/audio.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/modules/codec/avcodec/audio.c
> b/modules/codec/avcodec/audio.c
> > index a37f1cf..514f76d 100644
> > --- a/modules/codec/avcodec/audio.c
> > +++ b/modules/codec/avcodec/audio.c
> > @@ -261,7 +261,6 @@ int InitAudioDec( decoder_t *p_dec, AVCodecContext
> *p_context,
> > /* ***** Open the codec ***** */
> > if( OpenAudioCodec( p_dec ) < 0 )
> > {
> > - av_free( p_context->extradata );
> > free( p_sys );
> > return VLC_EGENERIC;
> > }
>
> I have a hard time seeing where the extradata is, in fact, freed.
>
> And I guess we have the same issue with subtitle part.
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150208/ede5a04b/attachment-0001.html>
------------------------------
Message: 8
Date: Sun, 8 Feb 2015 09:50:36 +0100
From: Jean-Baptiste Kempf <jb at videolan.org>
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Subject: Re: [vlc-devel] [PATCH] avcodec: fix double free on failure
to open audio
Message-ID: <20150208085036.GA10842 at videolan.org>
Content-Type: text/plain; charset=us-ascii
On 08 Feb, Alex Converse wrote :
> So it's freed in avcodec_free_context() its been freed there in all
> versions of libav and ffmpeg that have that function. It's also freed in
> the current version of VLC compat but not older versions.
Got it. thanks.
With my kindest regards,
--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
------------------------------
Subject: Digest Footer
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
https://mailman.videolan.org/listinfo/vlc-devel
------------------------------
End of vlc-devel Digest, Vol 93, Issue 9
****************************************
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150208/65997bd8/attachment.html>
More information about the vlc-devel
mailing list