[vlc-devel] Set of configure patches

[Martell Malone]

1.

> This patch makes no sense.
>
http://msdn.microsoft.com/en-us/library/windows/desktop/ms737931%28v=vs.85%29.aspx
We should be using this and not one that comes with vlc sources
Needless to say duplication linker errors etc. vlc won't compile on trunk
mingw-w64 without it.

If defines a macro that is not used anywhere.
>
The author told me it is there for readability so that config.h describes
the features that are and are not there.
If you don't want any unused defines I can change it to
])],[],[AC_LIBOBJ([freeaddrinfo])])
There is no issue there.

I expect its only effect will be to break the OS/2 build.
>
I agree with you that it would be a concern but
I highly doubt that it will as that program should build successfully for
OS/2 still resulting in AC_LIBOBJ([freeaddrinfo])

He wrote it because vlc commit 3180272a56bdb3933219e1cc2c57d0285a7adbd
broke building from mingw-w64

2.

> There is already code for this, so this patch is either redundant or wrong.
>

You are correct it is there already, I somehow missed this before.

You do have AC_CHECK_TYPES([struct pollfd]
but that comes with a
# define _WIN32_WINNT 0x502
which forces windows xp
I could submit a patch that removes this line if that is better suited then
actually detecting it via compiling.
Would that be acceptable ??

3.

> So fix mingw64?

 I actually submitteed a patch that was merged to create actual functions
for the time functions over previous defines
It was merged but there has been a lenghty discussion since where they have
opted for inline
I am not in charge of mingw-w64 so I can't change this.

No ways we had kilometers of copy paste code like this because they abuse
> inlines.

Yes you have a list of 2 items like this in configure.ac asprintf and
vasprintf.
This is just prepended to that list and is a must or the linker goes
absolutely crazy

Essentially I need this because I have a dx11 renderer that I want to
submit but it can only be built on trunk.
As much as I agree with you on abuse of inlines this one is a must for
building vlc with this :D

Kind Regards
Martell

On Tue, Jan 13, 2015 at 7:33 PM, Rémi Denis-Courmont <remi at remlab.net>
wrote:

> Le 2015-01-13 15:41, Martell Malone a écrit :
>
>> Attached are 3 patches that enhance building for windows with
>> configure.ac [1]
>>
>> 1. Search for freeaddrinfo in SOCKET_LIBS
>>
>> This patch was created by Ray Donnelly who I have CCd in this email.
>>
>
> This patch makes no sense. If defines a macro that is not used anywhere. I
> expect its only effect will be to break the OS/2 build.
>
>  2. Search for pollfd incase we are building for a target beyond
>> windows xp.
>>
>
> There is already code for this, so this patch is either redundant or wrong.
>
>  3. localtime_r and gmtime_r are now defined as inline in mingw64 and
>> are behind a guard _POSIX this patch fixes their discovery.
>>
>
> So fix mingw64? No ways we had kilometers of copy paste code like this
> because they abuse inlines.
>
> --
> Rémi Denis-Courmont
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150113/a5317ac3/attachment.html>