[vlc-devel] [PATCH] Navigation enhancement for language learning (Goldy Liang)
Goldy Liang
goldyliang at gmail.com
Tue Mar 3 22:01:32 CET 2015
Hi all,
Please kindly provide comments for the patch as titled. This is not a bug
fix patch but an enhancement. Especially whether the way of exposing the
subtitle data to interface module is acceptable or not.
Thank you!
Goldy
On Mon, Mar 2, 2015 at 6:00 AM, <vlc-devel-request at videolan.org> wrote:
> Send vlc-devel mailing list submissions to
> vlc-devel at videolan.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://mailman.videolan.org/listinfo/vlc-devel
> or, via email, send a message with subject or body 'help' to
> vlc-devel-request at videolan.org
>
> You can reach the person managing the list at
> vlc-devel-owner at videolan.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of vlc-devel digest..."
>
>
> Today's Topics:
>
> 1. Re: gpg keys outdated and expired (Jean-Baptiste Kempf)
> 2. [PATCH] MKV: do not hard define MKV_DEBUG (Steve Lhomme)
> 3. [PATCH] MKV: do not hard define MKV_DEBUG (Steve Lhomme)
> 4. [PATCH] MKV: do not hard define MKV_DEBUG (Steve Lhomme)
> 5. [PATCH] MKV: MKV_DEBUG is a define to set, not a particular
> value (Steve Lhomme)
> 6. [PATCH] Navigation enhancement for language learning (Goldy Liang)
> 7. [PATCH] Switch from DSA to RSA keys (Rafa?l Carr?)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Sun, 1 Mar 2015 12:09:58 +0100
> From: Jean-Baptiste Kempf <jb at videolan.org>
> To: Mailing list for VLC media player developers
> <vlc-devel at videolan.org>
> Subject: Re: [vlc-devel] gpg keys outdated and expired
> Message-ID: <20150301110958.GB501 at videolan.org>
> Content-Type: text/plain; charset=us-ascii
>
> On 28 Feb, wax wrote :
> > There is no indication on the website or wiki that builds are signed
> > with gpg. I did notice .asc file on the ftp. [1] Eventually I found
> > the keys on the ftp also. [2] But to my dismay not only was the key
> > using 1024 DSA it was also expired. It would be nice if the download
> > pages made mention of a gpg sig, along with updating the key to at least
> > 2048 bit RSA
>
> Update the key from the servers.
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
>
>
> ------------------------------
>
> Message: 2
> Date: Mon, 2 Mar 2015 09:50:38 +0100
> From: Steve Lhomme <robUx4 at videolabs.io>
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] MKV: do not hard define MKV_DEBUG
> Message-ID: <BLU436-SMTP1556522CA54703C3B6C41839A100 at phx.gbl>
> Content-Type: text/plain
>
> ---
> modules/demux/mkv/mkv.hpp | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/modules/demux/mkv/mkv.hpp b/modules/demux/mkv/mkv.hpp
> index 9cf6ccd..c052735 100644
> --- a/modules/demux/mkv/mkv.hpp
> +++ b/modules/demux/mkv/mkv.hpp
> @@ -99,8 +99,6 @@
> # include <zlib.h>
> #endif
>
> -#define MKV_DEBUG 0
> -
> #define MATROSKA_COMPRESSION_NONE -1
> #define MATROSKA_COMPRESSION_ZLIB 0
> #define MATROSKA_COMPRESSION_BLIB 1
> --
> 2.2.2
>
>
>
> ------------------------------
>
> Message: 3
> Date: Mon, 2 Mar 2015 10:06:13 +0100
> From: Steve Lhomme <robUx4 at videolabs.io>
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] MKV: do not hard define MKV_DEBUG
> Message-ID: <BLU437-SMTP73C5CB487A20CEA739D46B9A100 at phx.gbl>
> Content-Type: text/plain
>
> ---
> modules/demux/mkv/mkv.hpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/demux/mkv/mkv.hpp b/modules/demux/mkv/mkv.hpp
> index 9cf6ccd..cd80c2e 100644
> --- a/modules/demux/mkv/mkv.hpp
> +++ b/modules/demux/mkv/mkv.hpp
> @@ -99,7 +99,7 @@
> # include <zlib.h>
> #endif
>
> -#define MKV_DEBUG 0
> +//#define MKV_DEBUG 0
>
> #define MATROSKA_COMPRESSION_NONE -1
> #define MATROSKA_COMPRESSION_ZLIB 0
> --
> 2.2.2
>
>
>
> ------------------------------
>
> Message: 4
> Date: Mon, 2 Mar 2015 10:09:27 +0100
> From: Steve Lhomme <robUx4 at videolabs.io>
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] MKV: do not hard define MKV_DEBUG
> Message-ID: <BLU436-SMTP1677D0C068C41C31C33D9089A100 at phx.gbl>
> Content-Type: text/plain
>
> ---
> modules/demux/mkv/mkv.hpp | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/modules/demux/mkv/mkv.hpp b/modules/demux/mkv/mkv.hpp
> index 9cf6ccd..4e2963e 100644
> --- a/modules/demux/mkv/mkv.hpp
> +++ b/modules/demux/mkv/mkv.hpp
> @@ -99,7 +99,9 @@
> # include <zlib.h>
> #endif
>
> -#define MKV_DEBUG 0
> +#ifndef NDEBUG
> +//# define MKV_DEBUG 0
> +#endif
>
> #define MATROSKA_COMPRESSION_NONE -1
> #define MATROSKA_COMPRESSION_ZLIB 0
> --
> 2.2.2
>
>
>
> ------------------------------
>
> Message: 5
> Date: Mon, 2 Mar 2015 10:15:57 +0100
> From: Steve Lhomme <robUx4 at videolabs.io>
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] MKV: MKV_DEBUG is a define to set, not a
> particular value
> Message-ID: <BLU437-SMTP79F44F46D7D79D30BDA7BF9A100 at phx.gbl>
> Content-Type: text/plain
>
> ---
> modules/demux/mkv/virtual_segment.cpp | 4 ++--
> modules/demux/mkv/virtual_segment.hpp | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/modules/demux/mkv/virtual_segment.cpp
> b/modules/demux/mkv/virtual_segment.cpp
> index a41abb8..d9d0dc0 100644
> --- a/modules/demux/mkv/virtual_segment.cpp
> +++ b/modules/demux/mkv/virtual_segment.cpp
> @@ -207,7 +207,7 @@ virtual_edition_c::virtual_edition_c(
> chapter_edition_c * p_edit, std::vector<ma
> b_ordered = true;
> }
>
> -#if MKV_DEBUG
> +#ifdef MKV_DEBUG
> msg_Dbg( &p_main_segment->sys.demuxer, "-- RECAP-BEGIN --" );
> print();
> msg_Dbg( &p_main_segment->sys.demuxer, "-- RECAP-END --" );
> @@ -610,7 +610,7 @@ bool virtual_chapter_c::Leave( bool b_do_subs )
> return false;
> }
>
> -#if MKV_DEBUG
> +#ifdef MKV_DEBUG
> void virtual_chapter_c::print()
> {
> msg_Dbg( &p_segment->sys.demuxer, "*** chapter %"PRId64" - %"PRId64"
> (%u)",
> diff --git a/modules/demux/mkv/virtual_segment.hpp
> b/modules/demux/mkv/virtual_segment.hpp
> index ed40e59..46e9df2 100644
> --- a/modules/demux/mkv/virtual_segment.hpp
> +++ b/modules/demux/mkv/virtual_segment.hpp
> @@ -72,7 +72,7 @@ public:
> int64_t i_virtual_stop_time;
> int i_seekpoint_num;
> std::vector<virtual_chapter_c *> sub_chapters;
> -#if MKV_DEBUG
> +#ifdef MKV_DEBUG
> void print();
> #endif
> };
> @@ -101,7 +101,7 @@ public:
> private:
> void retimeChapters();
> void retimeSubChapters( virtual_chapter_c * p_vchap );
> -#if MKV_DEBUG
> +#ifdef MKV_DEBUG
> void print(){ for( size_t i = 0; i<chapters.size(); i++ )
> chapters[i]->print(); }
> #endif
>
> --
> 2.2.2
>
>
>
> ------------------------------
>
> Message: 6
> Date: Sun, 1 Mar 2015 13:05:57 -0500
> From: Goldy Liang <goldyliang at gmail.com>
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] Navigation enhancement for language
> learning
> Message-ID:
> <CAMn8pu2myx-i=
> 3Y5DJnv3znpbnC_Bqvtd5PvZcpZS_7JSdok7Q at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> Hi,
>
> Please find the patch of enhancement for language learning by adding
> navigation function based on subtitle data.
>
> Some background could be found in the forum thread:
>
> https://forum.videolan.org/viewtopic.php?f=18&t=122342&sid=9130404948aa59035d1fe6ff37b7194d
>
> Commit log:
>
> Navigation based on subtitle data (next/prev sentence, repeat sentence)
> New profile "Language learning style" for customize interface Added
> Slower/faster fine buttons Handle interaction between AtoB and sentence
> repeat
>
> More detail:
> - Escalated the subtitle data structure into vlc_subtitle.h
> - Added a field in the input thread internal data to point to the
> main subtitle data
> - Introduced API to set/reset/get the main subtitle data
> - Subtitle demux module invoked set to expose the subtitle data
> Invoked reset if subtitle unloaded (module closed)
> - qt4 interface module invoked get to access subtitle
> - qt4 interface enhanced to navigate via subtitle data, including
> * prev/next sentence
> * repeat current sentence
> - Menu enhanced to add related new entries
> - Toolbar buttons added for related functions
> - A new profile of customize interface named "Language learning style"
> - Added slower/faster fine buttons
> - Interaction between AtoB and sentence repeat mode
>
> Thank you for your review.
>
> Goldy
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150301/7e0915f7/attachment-0001.html
> >
> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: 0001-Navigation-based-on-subtitle-data-next-prev-sentence.patch
> Type: text/x-patch
> Size: 50784 bytes
> Desc: not available
> URL: <
> http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150301/7e0915f7/attachment-0001.bin
> >
>
> ------------------------------
>
> Message: 7
> Date: Mon, 2 Mar 2015 11:03:48 +0100
> From: Rafa?l Carr? <funman at videolan.org>
> To: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] Switch from DSA to RSA keys
> Message-ID: <1425290628-1782-1-git-send-email-funman at videolan.org>
>
> Change server address so old VLC versions continue to fetch a DSA signature
>
> ---
> TODO: actually generate a new key.
>
> In person at next meeting so we can store the key on our NSA^WGemalto
> hardware PGP keys?
>
> include/vlc_pgpkey.h | 1 -
> src/misc/update.c | 4 ++--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/vlc_pgpkey.h b/include/vlc_pgpkey.h
> index ea56210..7bd357b 100644
> --- a/include/vlc_pgpkey.h
> +++ b/include/vlc_pgpkey.h
> @@ -5,7 +5,6 @@
> /* We trust this public key, and by extension, also keys signed by it. */
>
> /* NOTE:
> - * We need a 1024 bits DSA key.
> * Don't forget to upload the key to
> http://download.videolan.org/pub/keys/
> */
>
> diff --git a/src/misc/update.c b/src/misc/update.c
> index e1257b7..003ccaf 100644
> --- a/src/misc/update.c
> +++ b/src/misc/update.c
> @@ -83,9 +83,9 @@
> #endif
>
> #ifndef NDEBUG
> -# define UPDATE_VLC_STATUS_URL "
> http://update-test.videolan.org/vlc/status-win-x86"
> +# define UPDATE_VLC_STATUS_URL "
> http://update2-test.videolan.org/vlc/status-win-x86"
> #else
> -# define UPDATE_VLC_STATUS_URL "http://update.videolan.org/vlc/status"
> UPDATE_OS_SUFFIX
> +# define UPDATE_VLC_STATUS_URL "http://update2.videolan.org/vlc/status"
> UPDATE_OS_SUFFIX
> #endif
>
>
> /*****************************************************************************
> --
> 2.3.1
>
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> vlc-devel mailing list
> vlc-devel at videolan.org
> https://mailman.videolan.org/listinfo/vlc-devel
>
>
> ------------------------------
>
> End of vlc-devel Digest, Vol 94, Issue 2
> ****************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20150303/ebdef462/attachment.html>
More information about the vlc-devel
mailing list