[vlc-devel] [PATCH 2/8] modules/stream_extractor: added libarchive extractor

[Filip Roséen]

Hi Hugo (and myself),

On 2017-01-23 15:58, Filip Roséen wrote:

> > > +                goto error;
> > > +        }
> > > +    }
> > > +
> > > +    p_sys->psz_additional_files = psz_data;
> 
> `(A)`: the above should be `psz_files`, and not `psz_data`.. though it
> is important to note that `private_sys_t::psz_additional_files` is not
> used anymore, and as such everything regarding that variable should be
> removed.

What I wrote above is incorrect, I forgot that the data that
`psz_additional_flags` refers to is indirectly used by other entities
in the implementation.

Given that I wrote the implementation, and now became confused a few
months after I originally wrote it -- I reckon a clean-up is in order.

Once again, thanks for the review and for making me confused
(hilighting the flaws in the implementation).
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170123/f7f8e578/attachment.html>