[vlc-devel] [PATCH v3 04/10] core: use refcounter helper for pictures

[Rémi Denis-Courmont]

Red herring. I never said that uint was enough for anything - except picture pool refs (which are bound to 65 IIRC). I even explicitly denied that already.

Le 4 juillet 2018 11:05:32 GMT+03:00, Romain Vimont <rom1v at videolabs.io> a écrit :
>On Wed, Jul 04, 2018 at 09:24:19AM +0300, Rémi Denis-Courmont wrote:
>> Reason was provided multiple times.
>> 
>> If you don't understand it, that's no excuse for bullshitting.
>
>OK, so let's review the reason you provided as comments of patch v2
>once
>again, so I get a chance to understand.
>
>> 1) This creates obvious overflow.
>
>> There was a protection and you removed it. By definition, we can
>> obviously not have more uintptr_max in-memory refs.
>
>> In other words, there was a protection: the type was wide enough.
>
>Maybe I missed something, but how does this explain why the refcount
>type for pictures has to be wider than the refcount type used for other
>objects?
>
>Are pictures refcounted more than what an "unsigned int" may provide?
>
>> Le 3 juillet 2018 23:17:14 GMT+03:00, Romain Vimont
><rom1v at videolabs.io> a écrit :
>> >No reason has been provided to keep a different type for pictures
>from
>> >any other refcounts. It seems the difference was accidental, so the
>> >types should now be made consistent.
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180704/92e328fb/attachment.html>