[vlc-devel] [PATCH 1/3] libvlc: libvlc_MetadataRequest: add option for no automatic recursion

[Thomas Guillem]

On Sat, Jul 21, 2018, at 07:25, Filip Roséen wrote:
> Hi Rémi,


> On 2018-07-21 08:22, Rémi Denis-Courmont wrote:


>>  That seems very unnatural to me, and is only likely to either
>>  perpetuate the problem (because people forget the flag), or trigger
>>  cargo-cult (because people copy the flag not figuring out why).
>>  IMO, there are no valid reasons why recursion depth should be
>>  ignored. This was a bug.> I definitely agree with you on the above, though I am afraid that this
> bug has now slipped out in the open and people being people, I would
> not be surprised if people actually depend on this behavior now.> It is possible to fix the issue by not changing the behavior of
> libvlc_MetadataRequest at all, though it involves accessing the
> *preparser* from the *libvlc object*, which to me is not ideal.> What do you think we can do about this? Input is much appreciated as I
> really want this whole mess cleaned up.
This function is only used by libvlc_media and the playlist engine.
When it's called from libvlc (then explicitly requested by an user), the
preparse_depth should be forced to 1, otherwise the preparsing could be
skipped. When this function is called from the playlist, the
preparse_depth should not be touched.
Btw, I don't like this function at all (the name is very bad). We could
remove it and implement what we want in libvlc and playlist.


> 


> Best Regards,
>  Filip
> 


> _________________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180723/c8c33e97/attachment.html>