[vlc-devel] [vlc-commits] Remove harmful HAVE_SEARCH_H

[Steve Lhomme]

On 2018-05-24 1:21 PM, Rémi Denis-Courmont wrote:
> I don't know what you meam by that.
>
> As noted multiple times, and as is obvious from its source code, 
> keysym.c is to generate a build-time tool.

You never said it's built as a tool until now, hence my question. In 
fact this file doesn't seem to be referenced in any makefile or script. 
So there's a reason I have no idea how it's supposed to be used.

So the revert is OK for this file but not the other two.

>
> Le 24 mai 2018 14:09:12 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
>
>     On 2018-05-24 12:47 PM, Rémi Denis-Courmont wrote:
>>     They have to do with this that config.h is meant for host code
>>     (CC), not for build code (BUILDCC).
>
>     And what does modules/video_output/xcb/keysym.c have to do with
>     BUILDCC ? It's only used to build fourcc_gen.
>
>>
>>     Le 24 mai 2018 13:39:54 GMT+03:00, Steve Lhomme
>>     <robux4 at ycbcr.xyz> a écrit :
>>
>>         On 2018-05-24 12:31 PM, Rémi Denis-Courmont wrote:
>>>         Yes.
>>>
>>>         Udev assumes a platform that always had search.h.
>>>
>>>         Keysym needs search.h to build and since HAVE_SEARCH_H is
>>>         never defined in build tool source code, it failed to build.
>>
>>         What do build tools have to do with this ? You modified
>>         modules/video_output/xcb/keysym.c
>>         That file is missing a config.h include. That would be an
>>         appropriate fix (and should be added nonetheless).
>>
>>         The other 2 files include config.h before the HAVE_SEARCH_H
>>         so shouldn't fail unless your system is broken.
>>
>>
>>>
>>>         Le 24 mai 2018 13:03:59 GMT+03:00, Steve Lhomme
>>>         <robux4 at ycbcr.xyz> a écrit :
>>>
>>>             No.
>>>
>>>
>>>             On 2018-05-24 11:59 AM, Rémi Denis-Courmont wrote:
>>>>             No. You broke it by over-zealously patching code,
>>>>             PulseAudio (useless), udev (useless) and the X keysym
>>>>             generator (plain wrong), when only DTV had a problem.
>>>>             -- 
>>>>             Envoyé de mon appareil Android avec Courriel K-9 Mail.
>>>>             Veuillez excuser ma brièveté.
>>>>
>>>>
>>>>             _______________________________________________
>>>>             vlc-devel mailing list
>>>>             To unsubscribe or modify your subscription options:
>>>>             https://mailman.videolan.org/listinfo/vlc-devel
>>>
>>>
>>>         -- 
>>>         Envoyé de mon appareil Android avec Courriel K-9 Mail.
>>>         Veuillez excuser ma brièveté.
>>>
>>>
>>>         _______________________________________________
>>>         vlc-devel mailing list
>>>         To unsubscribe or modify your subscription options:
>>>         https://mailman.videolan.org/listinfo/vlc-devel
>>
>>
>>     -- 
>>     Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>>     excuser ma brièveté.
>>
>>
>>     _______________________________________________
>>     vlc-devel mailing list
>>     To unsubscribe or modify your subscription options:
>>     https://mailman.videolan.org/listinfo/vlc-devel
>
>
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez 
> excuser ma brièveté.
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20180524/5d5b5974/attachment.html>