[vlc-devel] [vlc-commits] vout: start before creating the thread

[Rémi Denis-Courmont]

Hi, 

That's a ridiculous argument. VLC plugins have always been such that they would br run on any thread but not be re-entered. And that's a consequence of VLC always being multi-thread-based rather event-based. If you want an event based media framework, you have the wrong project.

Not to mention that the GL provider and GL surface abstractions were specifically designed to support multi-threading, unlike their predecessors. Or that I need the changes to fix outstanding issues assigned to me.

Le 31 janvier 2019 13:38:13 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>On Thu, Jan 31, 2019, at 12:06, Rémi Denis-Courmont wrote:
>> No. That's obviously a bug in your external code.
>
>VLC will very likely depends on bugged external codes when display is
>concerned.
>
>VLC handle so many different vout API: GL/GLES EGL/WGL/Apple, Vulkan,
>Direct 3D, wayland, X11.
>Each of these API can have bugged drivers or bugged implementation.
>Do we really want to add us an extra difficulty by having the "vout
>display" open() called from a different thread ?
>
>
>> 
>> Le 31 janvier 2019 13:00:24 GMT+02:00, Pierre Lamot
><pierre at videolabs.io> a écrit :
>>> Hi,
>>> 
>>> it looks like the commit "4c8af37efa8b4dddd62c4716ff0acbefc071745f"
>(vout: start before creating the thread) is causing issues:
>>> 
>>> we end up having calls on the OpenGL context from differents thread
>wich might not be supported by some implementations. 
>>> ie: when using external OpenGL rendering with Qt OpenGL
>implementation, Qt will throw an exception.
>>> 
>>> please revert
>>> 
>>> --
>>> Pierre Lamotvlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190131/8f0f80e9/attachment.html>