[vlc-devel] RTSP assertion failures due to missing config variables

[Thomas Guillem]

On Fri, Apr 24, 2020, at 09:14, Mark Lee wrote:
> Hi,
> 
> With latest master, when trying to play RTSP I see assertion failures in config/core.c where it asserts that a configuration value is not null.
> 
> These assertions are triggered by calls in modules/stream_out/rtsp.c:

Hello, thanks for the report !

> 
> RtspSetup() has this:
> 
>  rtsp->timeout = vlc_tick_from_sec(__MAX(0,var_InheritInteger(owner, "rtsp-timeout")));
>  char *user = var_InheritString(owner, "sout-rtsp-user");
>  char *pwd = var_InheritString(owner, "sout-rtsp-pwd");
> 
> RtspAddId() has this:
> 
>  char *user = var_InheritString(rtsp->owner, "sout-rtsp-user");
>  char *pwd = var_InheritString(rtsp->owner, "sout-rtsp-pwd");
> 
> It looks like these variables were removed from modules/stream_out/rtp.c as part of 3b684b:
> 
> - add_integer( "rtsp-timeout", 60, RTSP_TIMEOUT_TEXT,
> - RTSP_TIMEOUT_LONGTEXT, true )
> - add_string( "sout-rtsp-user", "",
> - RTSP_USER_TEXT, RTSP_USER_LONGTEXT, true )
> - add_password("sout-rtsp-pwd", "", RTSP_PASS_TEXT, RTSP_PASS_LONGTEXT)

I think the correct fix is to add back these 3 variables ^^

Rémi, what do you think ?

> 
> Consequently there's the assertion failures, and it's no longer possible to use VLC to setup a password protected RTSP stream is it?
> 
> 
> Regards,
> 
> -M.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200424/6b23a143/attachment.html>