[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

[Rémi Denis-Courmont]

Hi,

There's moving hacks around then there's moving hacks around. This hack was in the macOS build script. I don't think it belongs in the generic contribs files.

Le 30 avril 2020 12:47:44 GMT+03:00, "Martin Storsjö" <martin at martin.st> a écrit :
>On Thu, 30 Apr 2020, Rémi Denis-Courmont wrote:
>
>> Instead of building with the SDK for the target lowest version, they
>build
>> with the newest, so autoconf correctly detects stuff that's in the
>SDK but
>> not the target.
>
>Yeah, that's a known dilemma.
>
>In general, it's possible to get build systems that test for
>availability 
>to behave in these situations though - I'm pretty sure the contribs
>build 
>system already specifies -miphoneos-version-min somewhere.
>
>By adding -Werror=partial-availability on top of that, function checks 
>that actually include headers (instead of just blindly trying to link 
>against a symbol) will error out for functions that are introduced
>after 
>the minimum version.
>
>This is just a FYI (and potential future improvement) in any case and 
>orthogonal to the patch, which just moves the existing hacks around.
>
>// Martin

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200430/808e573b/attachment.html>