[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

Alexandre Janniaux ajanni at videolabs.io
Thu Apr 30 17:10:04 CEST 2020


I'm not sure to understand why since you cannot make it work
reliably in the build script alone.

You also refused a patch invoking the fact macosx/ios
developers shouldn't call build/configure script each time
they need to build, highlighting that is was self-inflicted
pain. This is exactly what I try to avoid here.

Initially I put the include hook insertion in config.mak
from the apple/build.sh script, but ePirat mentioned to me
that bootstrap was better since it worked for any darwin
platform. If the fact it is in bootstrap is annoying to you
I can move it back to the build script but I don't really
see what problem you're trying to highlight here.

> There's moving hacks around then there's moving hacks around.

Please not that the intent it not just moving a hack, but
mainly ensuring the build of contribs doesn't depends upon
your ac_cv_* build environment variable. Fixing this hack
is out of the scope of my darwin and autofoo skills.

Alexandre Janniaux

On Thu, Apr 30, 2020 at 03:27:03PM +0300, Rémi Denis-Courmont wrote:
> Hi,
> There's moving hacks around then there's moving hacks around. This hack was in the macOS build script. I don't think it belongs in the generic contribs files.
> Le 30 avril 2020 12:47:44 GMT+03:00, "Martin Storsjö" <martin at martin.st> a écrit :
> >On Thu, 30 Apr 2020, Rémi Denis-Courmont wrote:
> >
> >> Instead of building with the SDK for the target lowest version, they
> >build
> >> with the newest, so autoconf correctly detects stuff that's in the
> >SDK but
> >> not the target.
> >
> >Yeah, that's a known dilemma.
> >
> >In general, it's possible to get build systems that test for
> >availability
> >to behave in these situations though - I'm pretty sure the contribs
> >build
> >system already specifies -miphoneos-version-min somewhere.
> >
> >By adding -Werror=partial-availability on top of that, function checks
> >that actually include headers (instead of just blindly trying to link
> >against a symbol) will error out for functions that are introduced
> >after
> >the minimum version.
> >
> >This is just a FYI (and potential future improvement) in any case and
> >orthogonal to the patch, which just moves the existing hacks around.
> >
> >// Martin
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list