[vlc-devel] [PATCH v2 13/17] contrib: use makefile instead of environment variable

Rémi Denis-Courmont remi at remlab.net
Thu Apr 30 21:03:29 CEST 2020


Le torstaina 30. huhtikuuta 2020, 18.10.04 EEST Alexandre Janniaux a écrit :
> Hi,
> 
> I'm not sure to understand why since you cannot make it work
> reliably in the build script alone.

I don't even know what you are talking about here.

> You also refused a patch invoking the fact macosx/ios
> developers shouldn't call build/configure script each time
> they need to build, highlighting that is was self-inflicted
> pain.

Uh? Most if not all contrib rules will forcefully rerun their configure anyway 
when rebuilding. Not that you need to do that very often.

(And for VLC proper, you can't avoid rerunning it anyway. If you know what you 
are doing, enable the autoconf cache to speed configure up.)

> > There's moving hacks around then there's moving hacks around.
> 
> Please not that the intent it not just moving a hack, but
> mainly ensuring the build of contribs doesn't depends upon
> your ac_cv_* build environment variable. Fixing this hack
> is out of the scope of my darwin and autofoo skills.

I don't have any ac_cv_* variables in contribs that I'd know of.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list