[vlc-devel] [PATCH 09/12] network: io: Remove VLA usages
thomas at gllm.fr
Wed Dec 9 10:38:42 CET 2020
MSCV is a recent compiler, and we should support it (lot of open-source projects support mingw and msvc).
Some other projects tend to remove VLA usage : https://www.phoronix.com/scan.php?page=news_item&px=Linux-Kills-The-VLA
We need to decide what to do about your VLA, specially since we can go back (there are not that many VLA in VLC for now).
On Wed, Dec 9, 2020, at 10:31, Rémi Denis-Courmont wrote:
> VLA are required just like hosting and threads and atomics are required. By VLC, and in the case of VLAs also by C99.
> None of those are required by C11 and that's completely irrelevant, as VLC is not meant to run on bare metal or historical ISAs.
> Le 9 décembre 2020 11:25:50 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo at beauzee.fr> a écrit :
>> On Wed, Dec 9, 2020, at 10:20 AM, Rémi Denis-Courmont wrote:
>>> No it is not fine as already explained and as is obvious from reading
>>> most call sites.
>> AFAICS all callsites except lua handle the error explicitly. Lua forwards the fd to its own caller which is responsible for checking the return value as can be expected.
>> I don't understand why an additional error case is so problematic.
>> Also, as for the other patches, this can't be expected to compile everywhere, since VLA are not mandatory.
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel