[vlc-devel] [vlc-commits] mjpeg: fix leak

[Rémi Denis-Courmont]

Le maanantaina 8. kesäkuuta 2020, 13.34.19 EEST Steve Lhomme a écrit :
> On 2020-06-08 12:11, Rémi Denis-Courmont wrote:
> > Le maanantaina 8. kesäkuuta 2020, 12.47.17 EEST Steve Lhomme a écrit :
> >> This broke the Raspbian build because you're giving a demux_t* where a
> >> vlc_object_t* is expected. You need to use VLC_OBJECT().
> > 
> > No it does not.
> 
> It does not what ???

This patch does not break the build on Debian and derivatives.
I tested that much before pushing it.
 
> > If you enabled warning-as-errors, *you* broke it.
> 
> Everything built correctly until this commit appeared.

And still does.

> I did not push it.

So what? If you create a latent problem, the problem is not created by the 
first commit to expose it. You created the problem in the first place by adding 
that stupid flag.

> You can try to deflect the responsibility but you're the one who
> pushed it to master. And I'm sure there was a nice warning in your
> compiler telling you there was an odd pointer usage. And you decided not
> to care anyway.

You're the one deflecting your own responsibilities here. You enabled a 
compilation flag in spite of at least 2 TC members advising against it. This is 
a self-inflicted problem.

-- 
Реми Дёни-Курмон
http://www.remlab.net/